SRVOCF-1071: Change the delete action to an undeploy button - #181
Conversation
Rename the per-row delete icon button to an undeploy (power off) button with a custom confirmation message that clarifies the GitHub repository and code are preserved. Add an undeploy step to the setup guide and fix the guide title wording. Refs: SRVOCF-1071 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
openshift-ci-robot
added
the
jira/valid-reference
|
@Cragsmann: This pull request references SRVOCF-1071 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@Cragsmann: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| aria-label={t('Delete')} | ||
| icon={<TrashIcon />} | ||
| aria-label={t('Undeploy')} | ||
| icon={<PowerOffIcon />} |
There was a problem hiding this comment.
I personally dont feel like the icon choice is intuitive.
The problem is:
- A power icon reads as "power off on click," not "undeploy on click."
- A greyed-out power icon reads as "click to power on," not "undeploy is unavailable."
Even if "power on" were mapped to deploy, the visual state is inverted - the button appears actionable when it should be disabled, and vice versa.
This is also not adaptable for when we have the deploy functionality, a single-state icon button cannot represent both undeploy and deploy as the feature evolves
My options would be:
- kebab menu with the actual text - no risk of misinterpretation
UndoIconthat switches to a disabledPlayIconafter undeploy - visually communicates the inverse action is coming.PlayIconcan be enabled once deploy functionality is available.UndoIconthat switches to a disabled state after undeploy - simpler variant with no forward hint. Undeploy is clear, but the disabled state does not suggest a future deploy action.
We could also just go with option 2 and directly implement https://redhat.atlassian.net/browse/SRVOCF-1072 as it is the root of the confusion.
3 participants
Summary
Fixes SRVOCF-1071
Checklist
docs/ARCHITECTURE.md(if there are relevant changes to our layered architecture)docs/TESTING.md(if there are relevant changes to our testing framework or setup)